Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/840#discussion_r54286321
--- Diff: lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java ---
@@ -225,8 +231,13 @@ private void cleanUpAndFireCallback(SelectionKey key) {
key.interestOps(0);
// this ensures that the TAsyncMethod instance doesn't hang around
key.attach(null);
--- End diff --
I started working on another async issue (THRIFT-3680) on top of your
change.
As I actually ran your code, I think it immediately became evident that the
try-catch is simply for new checked exception, period.
In that case, I'd like to put cancel() to the **catch** part to restore the
original behavior.
Any concern for that ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
