Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/840#discussion_r53422103
--- Diff: lib/java/src/org/apache/thrift/async/TAsyncMethodCall.java ---
@@ -225,8 +231,13 @@ private void cleanUpAndFireCallback(SelectionKey key) {
key.interestOps(0);
// this ensures that the TAsyncMethod instance doesn't hang around
key.attach(null);
--- End diff --
Another implication of the current (pre-existing) design is that the client
cannot handle unordered or even queued calls.
IMO it should but that would need major rewrite.
(To be clear, testParallelCalls has bunches of concurrent clients each of
which does sequential calls)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
