[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225179#comment-15225179 ]
ASF GitHub Bot commented on THRIFT-3768: ---------------------------------------- GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/977 THRIFT-3768 fix TThreadedServer refactoring issues with client lifetime guarantees You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift defect/THRIFT-3768 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/977.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #977 ---- commit 3f44af8a474591eb0879983efc35534e17a0b533 Author: Jim King <jim.k...@simplivity.com> Date: 2016-04-04T22:12:49Z THRIFT-3768 fix TThreadedServer refactoring issues with client lifetime guarantees ---- > TThreadedServer may crash if it is destroyed immediately after it returns > from serve() > -------------------------------------------------------------------------------------- > > Key: THRIFT-3768 > URL: https://issues.apache.org/jira/browse/THRIFT-3768 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9.3 > Reporter: Ted Wang > Assignee: James E. King, III > Priority: Minor > > Here's a sequence that shows the race: > Thread-1 (Users of TThreadedServer): Calls TThreadedServer::stop(), which > calls interruptChildren and initiates the tearing down of client connections. > Thread-2: In TServerFramework::serve(), broke out of accept, and now blocks > in TThreadedServer::serve() waiting to drain all the clients. > Thread-3 (The connected client thread created by TThreadedServer): In > disposeConnectedClient, running because the server is shutting down and the > shared_ptr specified this function to be the cleanup function for the client. > This thread just returned from onClientDisconnected and now context switches. > Thread-2: TThreadedServer::serve() is notified that all of the clients have > disconnected and completes. > Thread-1: Joins on Thread-2 and destroys the server object because it is done. > Thread-3: Finally gets a chance to run, but now encounters undefined behavior > because it is still executing a member function of an object that has been > destroyed. > You can force this race in action if you put sleep(1) before > onClientDisconnected() in disposeConnectedClient -- This message was sent by Atlassian JIRA (v6.3.4#6332)