Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/980#issuecomment-214391825 Looking for an advocate to consider merging this. It passed all three builds with the exception of something that happened on the apache jenkins where a cppcheck file was not created: > [Cppcheck] Starting the cppcheck analysis. > [Cppcheck] No cppcheck test report file(s) were found with the pattern 'cppcheck-result.xml' relative to '/home/jenkins/jenkins-slave/workspace/Thrift-precommit'. Did you enter a pattern relative to the correct directory? Did you generate the XML report(s) for Cppcheck? > [Cppcheck] Parsing throws exceptions. No cppcheck test report file(s) were found with the pattern 'cppcheck-result.xml' relative to '/home/jenkins/jenkins-slave/workspace/Thrift-precommit'. Did you enter a pattern relative to the correct directory? Did you generate the XML report(s) for Cppcheck? > Build step 'Publish Cppcheck results' changed build result to FAILURE
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---