Github user tpcwang commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r61581424 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value) { { Synchronized s(workerMonitor_); - while (workerCount_ != workerMaxCount_) { + while (workerCount_ > goalCount) { --- End diff -- It is not accessing `workerMaxCount_` outside of a lock. See line 424 where it uses the `Synchronized` object which grabs the mutex that the monitor owns.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---