Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r61589086 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value) { { Synchronized s(workerMonitor_); - while (workerCount_ != workerMaxCount_) { + while (workerCount_ > goalCount) { --- End diff -- Old line 399 modifies it under the monitor ``monitor_`` and then old line 424 acquired it under a different monitor ``workerMonitor_``. One cannot use different monitors to control access to the same variable and expect any synchronization. This is why I squirrel away the new value into goalCount and use it later on.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---