Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1103#discussion_r81466362
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -292,28 +310,30 @@ class ThreadManager::Worker : public Runnable {
GlobalOutput.printf("[ERROR] task->run() raised an unknown
exception");
}
}
+ else if (task->state_ == ThreadManager::Task::TIMEDOUT &&
manager_->expireCallback_) {
+ manager_->expireCallback_(task->getRunnable());
+ manager_->expiredCount_++;
+ }
--- End diff --
Looks problematic after `mutex_.unlock()` above.
I guess you intend to unlock inside `if`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
