Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1103#discussion_r81467563
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -339,103 +357,88 @@ void ThreadManager::Impl::addWorker(size_t value) {
idMap_.insert(std::pair<const Thread::id_t, shared_ptr<Thread>
>((*ix)->getId(), *ix));
--- End diff --
`getId` always returns invalid ID for detached boost/std threads.
It only affects `add` method called from inside worker threads, which does
not seem to be happening in thrift servers' code (not completely sure).
A warning or an exception when passed such thread factories would be nice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
