Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1084#discussion_r87710644
--- Diff: compiler/cpp/src/thrift/generate/t_swift_3_generator.cc ---
@@ -0,0 +1,2553 @@
+/*
--- End diff --
This particular file shares more than half of its content with existing
t_swift_generator.cc.
While we can certainly do this, alternative would be to add a flag into
existing one.
See Node.js generator where we have separate `lib/nodejs` directory but
single t_js_generator.cc with `gen_node_` field.
As the difference is often new separate method calls, such a merging might
not introduce much of a clutter.
What do you think ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
