Github user apocolipse commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1084#discussion_r87716408
  
    --- Diff: compiler/cpp/src/thrift/generate/t_swift_3_generator.cc ---
    @@ -0,0 +1,2553 @@
    +/*
    --- End diff --
    
    While I don't disagree, I can potentially see future problems arising when 
I try to introduce namespacing via modules.  
    Additionally, Swift 2.x won't be supported by Apple any longer after 2.x 
next year, so that might make a good case to axe the old one and just call this 
the canonical `Swift` generator, thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to