[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665677#comment-15665677
]
ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r87931714
--- Diff: lib/cpp/src/thrift/transport/THeaderTransport.h ---
@@ -135,8 +141,9 @@ class THeaderTransport : public
TVirtualTransport<THeaderTransport, TFramedTrans
void transform(uint8_t* ptr, uint32_t sz);
uint16_t getNumTransforms() const {
- int trans = writeTrans_.size();
- return trans;
+ std::vector<uint16_t>::size_type trans = writeTrans_.size();
+ assert(trans <= UINT16_MAX);
--- End diff --
If your casting error checking is just debug asserts, then you might as
well stick with the casts.
My preference would be to throw an exception if the size is out of bounds.
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
