[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15530323#comment-15530323
]
ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1044
I have tended to use the C99 limit macros in the past, however either one
should be acceptable. I don't believe I have experienced issues with
numeric_limits before. Either solution should be portable going forward as
well so I don't see the need to favor one over the other.
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
