[
https://issues.apache.org/jira/browse/THRIFT-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665676#comment-15665676
]
ASF GitHub Bot commented on THRIFT-3873:
----------------------------------------
Github user ben-craig commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r87931893
--- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp ---
@@ -60,7 +60,7 @@
#endif // _WIN32
#endif
-#if defined(_WIN32) && (_WIN32_WINNT < 0x0600)
+#if defined(_WIN32) && (_WIN32_WINNT < 0x0600) && !defined(AI_ADDRCONFIG)
#define AI_ADDRCONFIG 0x0400
--- End diff --
You didn't break this, but this kind of thing is exactly what the platform
socket header is for. Defining constants that don't belong to us often leads
to trouble. Instead, we should be defining something like THRIFT_AI_ADDRCONFIG
that can either be the real AI_ADDRCONFIG or 0x0400.
> Fix various compiler warnings when using VS2010
> -----------------------------------------------
>
> Key: THRIFT-3873
> URL: https://issues.apache.org/jira/browse/THRIFT-3873
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0
> Environment: VS2010, Windows
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Trivial
>
> While verifying a defect I had to build the windows thrift C++ library and
> found a number of compiler warnings that needed to be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
