Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88791642
--- Diff: compiler/cpp/src/thrift/thriftl.ll ---
@@ -39,11 +39,17 @@
#endif
#ifdef _MSC_VER
-//warning C4102: 'find_rule' : unreferenced label
-#pragma warning(disable:4102)
-//avoid isatty redefinition
+#pragma warning( push )
+// warning C4267: 'argument' : conversion from 'size_t' to 'int', possible
loss of data
+#pragma warning( disable : 4267 )
+
+// warning C4102: 'find_rule' : unreferenced label
+#pragma warning( disable : 4102 )
+
+// avoid isatty redefinition
#define YY_NEVER_INTERACTIVE 1
+// no <unistd.h>
--- End diff --
unnecessary comment imho
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
