Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1128#discussion_r88791632
--- Diff: compiler/cpp/src/thrift/generate/t_go_generator.cc ---
@@ -433,7 +434,11 @@ std::string t_go_generator::camelcase(const
std::string& value) const {
if (islower(value2[i + 1])) {
value2.replace(i, 2, 1, toupper(value2[i + 1]));
}
- fix_common_initialism(value2, i);
+
+ if (i > std::numeric_limits<int>().max()) {
+ throw "integer overflow in t_go_generator::camelcase, value = " +
value;
--- End diff --
looks like some indentation problem (some time ago `make format` was
helping with such issues... but it might no longer work :/ )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
