Github user anatol commented on the issue:

    https://github.com/apache/thrift/pull/1147
  
    @allengeorge thanks for this great work!! A few comment I had earlier that 
looks unresolved
    
    - Name of the official crate should be `thrift`, not `rift`.
    - Fields with reserved names should be renamed to `type_` rather than to 
`res_type`.
    
    
    Also please squash all commits in `thrift-2945-pr` and rebase if needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to