[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15857442#comment-15857442
]
James E. King, III commented on THRIFT-4064:
--------------------------------------------
Looking over nodejs updates at
(http://packages.ubuntu.com/search?keywords=nodejs&searchon=names) I see that
in trusty they used 0.10.25 and then in xenial (which is 16.04 LTS) they used
4.2.6 (all the way through zesty). The node.js project is up to version 7.4.0
at this point and it looks like anything below version 6.x is stale. I'm kind
of surprised that Ubuntu is staying with 4.2.6 through the zesty release. I
would have expected them to upgrade to at least 6.x there.
I found this resource for installing node.js on ubuntu:
https://nodejs.org/en/download/package-manager/#debian-and-ubuntu-based-linux-distributions
When I load https://deb.nodesource.com/ in the browser it actually takes me to
https://github.com/nodesource/distributions
>From there we can easily choose from 4.x through 7.x as the foundation we want
>to build against.
Try applying the following changes to your pull request. It will update the
build image to use node.js 4.7.3 which appears to be the latest 4.x stable. I
was able to complete a build using this locally inside the docker instance:
{noformat}
diff --git a/build/docker/ubuntu/Dockerfile b/build/docker/ubuntu/Dockerfile
index 02f0b1e5..1102c7d6 100644
--- a/build/docker/ubuntu/Dockerfile
+++ b/build/docker/ubuntu/Dockerfile
@@ -131,11 +131,11 @@ RUN apt-get update && apt-get install -y
--no-install-recommends \
neko-dev \
libneko0
-RUN apt-get update && apt-get install -y --no-install-recommends \
+# Node.js dependencies - THRIFT-4064 says it must be >= 4.x
+RUN curl -sL https://deb.nodesource.com/setup_4.x | bash -
+RUN apt-get install -y --no-install-recommends \
`# Node.js dependencies` \
- nodejs \
- nodejs-dev \
- nodejs-legacy
+ nodejs
RUN apt-get update && apt-get install -y --no-install-recommends \
`# CSharp dependencies` \
@@ -183,9 +183,6 @@ RUN mkdir -p /usr/lib/haxe && \
haxelib setup /usr/lib/haxe/lib && \
haxelib install hxcpp
-# Node.js
-RUN curl -sSL https://www.npmjs.com/install.sh | sh
-
# D
RUN curl -sSL
http://downloads.dlang.org/releases/2.x/2.070.0/dmd_2.070.0-0_amd64.deb -o
/tmp/dmd_2.070.0-0_amd64.deb && \
dpkg -i /tmp/dmd_2.070.0-0_amd64.deb && \
{noformat}
I ran "make cross" and "dpkg-buildpackage -d -tc" successfully inside the
docker instance with your pull request change and this one together.
{noformat}
root@0cbee6f081bc:/thrift# node --version
v4.7.3
{noformat}
> Update node library dependencies
> --------------------------------
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.10.0
> Reporter: Andres Suarez
>
> ws@0.4.32 is really old and presents issues for users using modern versions
> of Node (see
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should
> be updated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
