[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862257#comment-15862257
]
ASF GitHub Bot commented on THRIFT-4064:
----------------------------------------
Github user bgould commented on the issue:
https://github.com/apache/thrift/pull/1175
@zertosh can you elaborate on
> Alternatively, how do you feel about making the require call for this
module
configurable?(https://github.com/apache/thrift/blob/e1832c354391deb0e0ce94a62ff32e8ce1c83fd3/compiler/cpp/src/thrift/generate/t_js_generator.cc#L412)
Here's why I'm interested... I run the node library through browserify
which works but by default produces a much larger glob of javascript than I
really need, due to all of the thrift node components requiring that file which
pulls in all of the other components whether I need them or not (eg I don't
want to pull in TCompactProtocol or TFramedTransport etc if I'm just using
TXHRTransport and TBinaryProtocol in the browser). At the moment I'm using
some local edits to reduce what gets included by `require('thrift')` but IIRC
the last time I looked at it, I came to the conclusion that the
`require('thrift')` might not be needed at all (i.e., the modules that it
aggregates can just be included explicitly and individually as needed). I
would make code in the compiler possibly a bit more complicated but it could be
worth the effort.
> Update node library dependencies
> --------------------------------
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.10.0
> Reporter: Andres Suarez
> Assignee: James E. King, III
>
> ws@0.4.32 is really old and presents issues for users using modern versions
> of Node (see
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should
> be updated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
