[
https://issues.apache.org/jira/browse/THRIFT-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15862134#comment-15862134
]
ASF GitHub Bot commented on THRIFT-4064:
----------------------------------------
Github user zertosh commented on the issue:
https://github.com/apache/thrift/pull/1175
@jeking3 pretty sure that the "SyntaxError: Parse error" error is
phanthomjs (via run-browser) choking on the new syntax. The tests are running
phantomjs@1.9.20 (https://travis-ci.org/apache/thrift/jobs/200386738#L2252),
but it seems that it's v2 that added ES6 support (see
https://github.com/ariya/phantomjs/issues/14506).
Alternatively, how do you feel about making the `require` call for this
module
configurable?(https://github.com/apache/thrift/blob/e1832c354391deb0e0ce94a62ff32e8ce1c83fd3/compiler/cpp/src/thrift/generate/t_js_generator.cc#L412)
> Update node library dependencies
> --------------------------------
>
> Key: THRIFT-4064
> URL: https://issues.apache.org/jira/browse/THRIFT-4064
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.10.0
> Reporter: Andres Suarez
> Assignee: James E. King, III
>
> ws@0.4.32 is really old and presents issues for users using modern versions
> of Node (see
> https://github.com/apache/thrift/pull/672#issuecomment-276678791). Its should
> be updated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
