[
https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931483#comment-15931483
]
ASF GitHub Bot commented on THRIFT-2026:
----------------------------------------
Github user jbapple-cloudera commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1214#discussion_r106794199
--- Diff: compiler/cpp/src/thrift/parse/t_field.h ---
@@ -68,7 +68,7 @@ class t_field : public t_doc {
int32_t get_key() const { return key_; }
- enum e_req { T_REQUIRED, T_OPTIONAL, T_OPT_IN_REQ_OUT };
+ enum e_req : unsigned { T_REQUIRED, T_OPTIONAL, T_OPT_IN_REQ_OUT };
--- End diff --
Got it. Should I add a new patch to this pull request or squash them into
one patch on this pull request?
> Fix TCompactProtocol 64 bit builds
> ----------------------------------
>
> Key: THRIFT-2026
> URL: https://issues.apache.org/jira/browse/THRIFT-2026
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Mac 64, Win 64, Linux 64
> Reporter: Ben Craig
> Assignee: Ben Craig
> Fix For: 0.9.2
>
> Attachments: compact_int_stuff.patch
>
>
> TCompactProtocol has several places where it truncates a size_t to a 32-bit
> value.
> TCompactProtocol also does bitwise operations on signed values, which has
> undefined behavior.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
