[
https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941677#comment-15941677
]
ASF GitHub Bot commented on THRIFT-2026:
----------------------------------------
Github user jbapple-cloudera commented on the issue:
https://github.com/apache/thrift/pull/1214
OK, this new patch does not change the definitions of any `enum`s, only
their usages. It also adds undefined behavior checking to the pre-merge CI
tests on Travis to discourage regressions.
> Fix TCompactProtocol 64 bit builds
> ----------------------------------
>
> Key: THRIFT-2026
> URL: https://issues.apache.org/jira/browse/THRIFT-2026
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Mac 64, Win 64, Linux 64
> Reporter: Ben Craig
> Assignee: Ben Craig
> Fix For: 0.9.2
>
> Attachments: compact_int_stuff.patch
>
>
> TCompactProtocol has several places where it truncates a size_t to a 32-bit
> value.
> TCompactProtocol also does bitwise operations on signed values, which has
> undefined behavior.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
