[ https://issues.apache.org/jira/browse/THRIFT-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931502#comment-15931502 ]
ASF GitHub Bot commented on THRIFT-2026: ---------------------------------------- Github user jbapple-cloudera commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106794729 --- Diff: lib/c_glib/src/thrift/c_glib/protocol/thrift_compact_protocol.c --- @@ -120,7 +120,11 @@ thrift_bitwise_cast_gdouble (const guint64 v) static guint64 i64_to_zigzag (const gint64 l) { - return (l << 1) ^ (l >> 63); --- End diff -- Negative input is expected: https://github.com/apache/thrift/blob/796667b29f91682871cec310571e66b1259fffb0/lib/cpp/src/thrift/protocol/TCompactProtocol.tcc#L385 Also, changing the input to unsigned would actually break this, because the right shift depends on being an arithmetic shift, not a logical one. > Fix TCompactProtocol 64 bit builds > ---------------------------------- > > Key: THRIFT-2026 > URL: https://issues.apache.org/jira/browse/THRIFT-2026 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.9 > Environment: Mac 64, Win 64, Linux 64 > Reporter: Ben Craig > Assignee: Ben Craig > Fix For: 0.9.2 > > Attachments: compact_int_stuff.patch > > > TCompactProtocol has several places where it truncates a size_t to a 32-bit > value. > TCompactProtocol also does bitwise operations on signed values, which has > undefined behavior. -- This message was sent by Atlassian JIRA (v6.3.15#6346)