[ https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305410#comment-16305410 ]
ASF GitHub Bot commented on THRIFT-4423: ---------------------------------------- Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1445#discussion_r158937682 --- Diff: lib/php/test/Makefile.am --- @@ -17,6 +17,8 @@ # under the License. # +PHPUNIT=./../../../vendor/bin/phpunit --- End diff -- Is this relative path going to work on every platform? > migrate php library to psr-4 > ---------------------------- > > Key: THRIFT-4423 > URL: https://issues.apache.org/jira/browse/THRIFT-4423 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library > Affects Versions: 0.11.0 > Reporter: Robert Lu > > The latest autoload standard is [http://www.php-fig.org/psr/psr-4/]. > So, I migrate thrift to PSR-4. -- This message was sent by Atlassian JIRA (v6.4.14#64029)