[
https://issues.apache.org/jira/browse/THRIFT-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305408#comment-16305408
]
ASF GitHub Bot commented on THRIFT-4423:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1445#discussion_r158937524
--- Diff: build/docker/run.sh ---
@@ -25,6 +25,8 @@ DOCKER_TAG=$DOCKER_REPO:$DISTRO
printenv | sort
+composer install
--- End diff --
This looks like it should be part of the php section of the Dockerfile. By
putting it in the run section, we run "composer install" on the host and then
start a docker environment which doesn't have access to it.
> migrate php library to psr-4
> ----------------------------
>
> Key: THRIFT-4423
> URL: https://issues.apache.org/jira/browse/THRIFT-4423
> Project: Thrift
> Issue Type: Improvement
> Components: PHP - Library
> Affects Versions: 0.11.0
> Reporter: Robert Lu
>
> The latest autoload standard is [http://www.php-fig.org/psr/psr-4/].
> So, I migrate thrift to PSR-4.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
