Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1496#discussion_r174494320
  
    --- Diff: lib/java/gradle/unitTests.gradle ---
    @@ -68,6 +68,20 @@ test {
         include '**/Test*.class'
         exclude '**/Test*\$*.class'
     
    +    println 'Check if msvc.profile exists'
    --- End diff --
    
    It seems to me this fix is in the wrong place.  I don't like having the C++ 
compiler type passed down into the java build so it can disable a test.  The 
compiler code be modified somehow.



---

Reply via email to