Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1496#discussion_r174771623
--- Diff: test/DoubleConstantsTest.thrift ---
@@ -0,0 +1,17 @@
+namespace java thrift.test
+namespace cpp thrift.test
+
+// more tests on double constants (precision and type checks)
--- End diff --
There's probably another way to resolve this, such as fixing a compiler
flag being passed to older MSVC2013 compilers. I'll swing back around to this
one when I can. I don't like the notion that we say, "because the compiler was
built with MSVC2013, let's disable a test". Shouldn't any thrift compiler,
regardless of the C++ compiler used to create it, produce working thrift
generated code that has the same values as any other thrift compiler?
---
