Dear All:
Improve thrift support HTTP/1 test case PR: https://github.com/apache/thrift/pull/1866 How about that look like? Could anyone review it ? Thanks. Zhohu. At 2019-09-05 21:39:30, "pzh" <piaopiaohu...@163.com> wrote: Hi Jens,Randy,Christopher: According to the plan we discussed, I am currently improving the HTTP/1 test case. First of all, I found that the servlet 2.5 dependency package is relatively old, and users need to create the http environment themselves, so I added the embedded package of tomcat, Second, i improved the test case of the http application layer, so the client and server can communicate with each other and print the string. It can work now, and i have submitted the PR, hope it is what we want. I have tested it on Windows (Windows 10) and Linux (ubuntu 14.04), and the test cases can be sent and received normally. also i want to discuss the next plan with you: 1. The http application test case server-side code is missing. Do you need to continue to add more use cases? 2. I found that the latest master branch has been upgraded to openJDK 11, but not all of project`s modules be covered, some areas have not been modified, do you need to improve? After completing the above 2 tasks, i think we can start HTTP/2 support in one week later. Best Regards. Zhouhu. 在 2019-09-01 21:41:45,"Jens Geyer" <jensge...@hotmail.com> 写道: > >Ok, but what and when will there be new stable version suitable to switch >to? > > >-----Ursprüngliche Nachricht----- >From: Christopher >Sent: Sunday, September 1, 2019 7:27 AM >To: dev@thrift.apache.org >Subject: Re: Re: [Discussion] Should thrift-java support HTTP/2 ? > >I'd strongly advise against updating the JDK requirement to 12. >Requiring JDK 11 is better, because it's considered a long-term stable >(LTS) release, and it's the latest such release. JDK 12 is not; it is >a "rapid release" to preview features which will be in the next LTS, >and support for 12 ends this month. >https://en.wikipedia.org/wiki/Java_version_history > >On Fri, Aug 30, 2019 at 10:47 PM pzh <piaopiaohu...@163.com> wrote: >> >> Hi,Jens and Randy: >> i`m working on that now, how about this plan: >> >> 1. run all the test case for httpclient HTTP/1 in lib and find the >> problems exist. >> 2. update JDK 0.8 to JDK 0.11 at least, maybe JDK0.12 be better, >> need confirmed in next step. >> 3. port all the httpclinet HTTP/2 code in lib and add test case for >> that. >> >> >> Any other supplementary advice? >> >> >> Maybe we need 2 or 3 weeks for the first demo, will need more >> details discussion and help from you in future. >> >> Thanks. >> Zhouhu. >> >> >> >> >> >> >> >> >> >> 在 2019-08-30 02:04:11,"Jens Geyer" <jensge...@hotmail.com> 写道: >> > >> >+1 in general, except for the library dependencies. >> >If upgrading Java is a realistic option (I don't use it myself), I am >> >more >> >in favour of that solution. >> > >> >JensG >> > >> > >> >-----Ursprüngliche Nachricht----- >> >From: Randy Abernethy >> >Sent: Thursday, August 29, 2019 3:22 PM >> >To: dev@thrift.apache.org >> >Subject: Re: [Discussion] Should thrift-java support HTTP/2 ? >> > >> >+1 for http/2 support >> > >> > >> >On Thu, Aug 29, 2019, 08:19 pzh <piaopiaohu...@163.com> wrote: >> > >> >> HTTP/1, is a little out of date, so i propose to replace HttpClient >> >> with a >> >> third-party jar that supports HTTP/2, such as OkHttp, or upgrade the >> >> java >> >> version that supports HTTP/2. >> > >> > >