Hey Annie, The diff went away and is attached as a file? Can you change it to upload diff (not a file)? Thanks!
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Chris Mattmann, Ph.D. Chief Architect Instrument Software and Science Data Systems Section (398) NASA Jet Propulsion Laboratory Pasadena, CA 91109 USA Office: 168-519, Mailstop: 168-527 Email: chris.a.mattm...@nasa.gov WWW: http://sunset.usc.edu/~mattmann/ ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Adjunct Associate Professor, Computer Science Department University of Southern California, Los Angeles, CA 90089 USA ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ -----Original Message----- From: Tyler Palsulich <tpalsul...@gmail.com> Reply-To: "dev@tika.apache.org" <dev@tika.apache.org>, Tyler Palsulich <tpalsul...@gmail.com> Date: Saturday, June 7, 2014 10:06 AM To: Chris Mattmann <mattm...@apache.org> Cc: tika <dev@tika.apache.org>, "Bryant, Ann C (398J-Affiliate)" <anniebry...@gmail.com>, Tyler Palsulich <tpalsul...@gmail.com> Subject: Re: Review Request 22246: New parser for Matlab .mat files > >----------------------------------------------------------- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apache.org/r/22246/#review45019 >----------------------------------------------------------- > > >One more step for making the diff -- you have to run `svn add [file]` on >all of the new files (the Parser and ParserTest). That way, they will be >incorporated into the diff. When you run `svn status`, files with a '?' >entry will not be in the diff, but ones with an 'A' will (along with the >already-existing-but-modified 'M' files). > >- Tyler Palsulich > > >On June 6, 2014, 11:07 p.m., Ann Burgess wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/22246/ >> ----------------------------------------------------------- >> >> (Updated June 6, 2014, 11:07 p.m.) >> >> >> Review request for tika and Chris Mattmann. >> >> >> Repository: tika >> >> >> Description >> ------- >> >> This is a new parser for Matlab .mat files. The parser utilizes the >>JmatIO, Matlab's MAT-file I/O API in JAVA. JmatIO is available through >>Maven Central. The text output from this parser provides variable names >>and dimensions that are both inside and outside of data structures, but >>does NOT provide the actual data values within each .mat file. >> >> >> Diffs >> ----- >> >> >> Diff: https://reviews.apache.org/r/22246/diff/ >> >> >> Testing >> ------- >> >> Successfully run a basic unit test that checks both --text and >>--metadata parser output. >> >> >> File Attachments >> ---------------- >> >> TIKA-1327.aburgess.140606.patch.txt >> >>https://reviews.apache.org/media/uploaded/files/2014/06/06/3babeb42-6e15- >>4d31-ae7d-9dc7ef4c5f65__TIKA-1327.aburgess.140606.patch.txt >> >> >> Thanks, >> >> Ann Burgess >> >> >
