-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22246/#review45126
-----------------------------------------------------------



trunk/tika-parsers/pom.xml
<https://reviews.apache.org/r/22246/#comment79787>

    Leave this as 4.2.20?



trunk/tika-parsers/pom.xml
<https://reviews.apache.org/r/22246/#comment79788>

    Same -- leave this as 1.6.1?



trunk/tika-parsers/src/test/java/org/apache/tika/parser/mat/MatParserTest.java
<https://reviews.apache.org/r/22246/#comment79796>

    Weird whitespace here. Try converting all tabs to 4 spaces.


- Tyler Palsulich


On June 9, 2014, 8:11 p.m., Ann Burgess wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22246/
> -----------------------------------------------------------
> 
> (Updated June 9, 2014, 8:11 p.m.)
> 
> 
> Review request for tika and Chris Mattmann.
> 
> 
> Repository: tika
> 
> 
> Description
> -------
> 
> This is a new parser for Matlab .mat files.  The parser utilizes the JmatIO, 
> Matlab's MAT-file I/O API in JAVA. JmatIO is available through Maven Central. 
>  The text output from this parser provides variable names and dimensions that 
> are both inside and outside of data structures, but does NOT provide the 
> actual data values within each .mat file. 
> 
> 
> Diffs
> -----
> 
>   trunk/tika-core/src/main/resources/org/apache/tika/mime/tika-mimetypes.xml 
> 1601492 
>   trunk/tika-parsers/pom.xml 1601492 
>   trunk/tika-parsers/src/main/java/org/apache/tika/parser/mat/MatParser.java 
> PRE-CREATION 
>   
> trunk/tika-parsers/src/test/java/org/apache/tika/parser/mat/MatParserTest.java
>  PRE-CREATION 
>   
> trunk/tika-parsers/src/test/resources/test-documents/breidamerkurjokull_radar_profiles_2009.mat
>  UNKNOWN 
> 
> Diff: https://reviews.apache.org/r/22246/diff/
> 
> 
> Testing
> -------
> 
> Successfully run a basic unit test that checks both --text and --metadata 
> parser output.  
> 
> 
> File Attachments
> ----------------
> 
> TIKA-1327.aburgess.140606.patch.txt
>   
> https://reviews.apache.org/media/uploaded/files/2014/06/06/3babeb42-6e15-4d31-ae7d-9dc7ef4c5f65__TIKA-1327.aburgess.140606.patch.txt
> 
> 
> Thanks,
> 
> Ann Burgess
> 
>

Reply via email to