I'll clarify a little bit - I missed a piece of Pieter's email. I focused on the "thread interruption" but he also mentioned a problem with tail() - which Jason Plurad has already submitted a PR for:
https://github.com/apache/tinkerpop/pull/363 In this case the bug is on our side in TinkerPop but it only affects certain implementation in the right combinations of steps that include bulking (according to Jason). Given Jason's assessment and my earlier description of what -1 means, I think we should continue with release. Happy to hear if others think differently.... As a separate note, Pieter also brought up on HipChat that this was a shortened release test period. Apologies for that. The PR review queue got too deep toward the end of code freeze. We probably should have delayed the VOTE for a full seven days. I don't know if we need more than 10 days (7 in freeze and 3 in VOTE) for testing but if someone would like to bring that up as a separate thread please do. For me, I think we should just better stick to our full seven day freeze and not meld it up with PR reviews and such. Finally, we can release more often now if we like. We have less overhead now that we dont' have to go through incubator for release. Perhaps we plan to get a 3.2.2 out sooner than later with Jason's fix and a couple other odds and ends we wanted in 3.2.1 that didn't make it. Again, another discussion for another thread. On Wed, Jul 20, 2016 at 12:50 PM, Daniel Kuppitz <m...@gremlin.guru> wrote: > > > > imo, a -1 should be reserved for when there is a massive bug that brings > down > > the house > > > I concur. I've also found some nasty bugs in OLAP during my tests and even > if without a workaround I would probably have voted +1, as this has nothing > to do with the release. > > you have a single backend for Sqlg > > > That's another good point. If all tests pass for our reference > implementations (TinkerGraph and Neo4j), why should a failing test in > another 3rd party implementation block our release? AFAIK there are also > still issues in Titan, but that's a Titan thing, not a TinkerPop issue. > > Cheers, > Daniel > > > > > On Wed, Jul 20, 2016 at 6:01 PM, Stephen Mallette <spmalle...@gmail.com> > wrote: > > > Pieter, Thanks as usual for testing. I would offer than this is not a > case > > for a -1. Note that a -1 says we abort the release completely. > > > > imo, a -1 should be reserved for when there is a massive bug that brings > > down the house - meaning the system is abend in some way and there are no > > workarounds. a -1 might also be presented if the packaging is bad > somehow - > > like we didn't include the documentation in the zips. i could also see a > -1 > > if somehow a GPL'd dependency snuck into our packaging somehow or we > > otherwise violated Apache licensing. If other's don't agree, I hope > they'll > > say so. > > > > in this case, you have a single backend for Sqlg that is failing a single > > test that you can temporarily OptOut of for your tests to pass. Users > don't > > specifically have a workaround for this problem if they use Sqlg and > > HSQLDB, but it's less of a "bug" and more of a feature that they can't > use > > (i.e. they can't interrupt a running traversal). To me, I don't think we > > need to stop release of TinkerPop over that narrow case. > > > > Would you reconsider your -1 based on that logic? > > > > > > > > On Wed, Jul 20, 2016 at 11:45 AM, pieter-gmail <pieter.mar...@gmail.com> > > wrote: > > > > > Hi, > > > > > > Ran all Sqlg's tests and the process and structured test suites. > > > But alas there are failures. > > > > > > TraversalInterruptionTest are failing on HSQLDB as the > > > Thread.interrupt() is intercepted by them and the interrupt flag is > > reset. > > > The TraversalInterruptionTest tests themselves suffers from this as its > > > own Thread.sleep() logic resets the interrupt flag and requires special > > > resetting. I'd say the current interrupt strategy needs rethinking. > > > > > > TailTest.g_V_repeatXbothX_timesX3X_tailX7X fails. I added a few more, > > > repeat followed by a tail step, tests in sqlg, all of which also fails. > > > Jason has already proposed a fix for this here > > > <https://issues.apache.org/jira/browse/TINKERPOP-1379>. > > > > > > vote -1 > > > > > > Thanks > > > Pieter > > > > > > > > > > > > On 19/07/2016 15:20, Stephen Mallette wrote: > > > > Hello, > > > > > > > > We are happy to announce that TinkerPop 3.2.1 is ready for release - > > note > > > > the lack of "-incubating" everywhere. :) > > > > > > > > The release artifacts can be found at this location: > > > > https://dist.apache.org/repos/dist/dev/tinkerpop/3.2.1/ > > > > > > > > The source distribution is provided by: > > > > apache-tinkerpop-3.2.1-src.zip > > > > > > > > Two binary distributions are provided for user convenience: > > > > apache-gremlin-console-3.2.1-bin.zip > > > > apache-gremlin-server-3.2.1-bin.zip > > > > > > > > The GPG key used to sign the release artifacts is available at: > > > > https://dist.apache.org/repos/dist/dev/tinkerpop/KEYS > > > > > > > > The online docs can be found here: > > > > http://tinkerpop.apache.org/docs/3.2.1/reference/ (user docs) > > > > http://tinkerpop.apache.org/docs/3.2.1/upgrade/ (upgrade docs) > > > > http://tinkerpop.apache.org/javadocs/3.2.1/core/ (core javadoc) > > > > http://tinkerpop.apache.org/javadocs/3.2.1/full/ (full javadoc) > > > > > > > > The tag in Apache Git can be found here: > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=tinkerpop.git;a=tag;h=c5a9e2815e76f044e6b33b773b6bb0bb048270cc > > > > > > > > The release notes are available here: > > > > > > > > > > https://github.com/apache/tinkerpop/blob/3.2.1/CHANGELOG.asciidoc#release-3-2-1 > > > > > > > > The [VOTE] will be open for the next 72 hours --- closing Friday > (July > > > 22, > > > > 2016) at 9:30 am EST. > > > > > > > > My vote is +1. > > > > > > > > Thank you very much, > > > > Stephen > > > > > > > > > > > > >
