[
https://issues.apache.org/jira/browse/TINKERPOP-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15655821#comment-15655821
]
ASF GitHub Bot commented on TINKERPOP-1545:
-------------------------------------------
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/486
The `PathProcessor` interface has no function for SimpleStep and doesn't
add any overhead. AFAIK `PathProcessor` is only used by strategies to easily
identify traversals with "special requirements". Both, `SimpleStep` and
`CyclicStep`, access the current `traverser.path()` and thus they **process**
the **path**, which makes them `PathProcessor`s :).
I can also rely on the result of `getRequirements()`, but this would make
the strategy a bit slower and I really don't see why `SimplePath` and
`CyclicPath` should not be `PathProcessor`s.
> IncidentToAdjacentStrategy is buggy
> -----------------------------------
>
> Key: TINKERPOP-1545
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1545
> Project: TinkerPop
> Issue Type: Bug
> Affects Versions: 3.1.4, 3.2.3
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> {{IncidentToAdjacentStrategy}} turns {{outE().inV().simplePath()}} into
> {{out().simplePath()}}, which will return a wrong result as soon as there is
> more than 1 edge between a pair of vertices.
> The set {{INVALIDATING_STEP_CLASSES}} should only contain
> {{PathProcessor.class}} and {{LambdaHolder.class}} Furthermore
> {{SimplePathStep}} should implement {{PathProcessor}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
