[
https://issues.apache.org/jira/browse/TINKERPOP-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15656993#comment-15656993
]
ASF GitHub Bot commented on TINKERPOP-1545:
-------------------------------------------
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/486
Why do you do a root recursion on every traversal? Why not use the "marker
model" ? Also, `getRequirements()` is already recursive off the root traversal
steps. I would do this:
1. If root -- search for `SimplePathStep`, `CyclicPathStep`,
`LambdaHolder`, `Path`, `Tree`, ?
2. If one exists, mark all child traversals with hidden label.
3. If a child - am I marked, yes? remove the mark and return. No? do the
rewrite.
> IncidentToAdjacentStrategy is buggy
> -----------------------------------
>
> Key: TINKERPOP-1545
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1545
> Project: TinkerPop
> Issue Type: Bug
> Affects Versions: 3.1.4, 3.2.3
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> {{IncidentToAdjacentStrategy}} turns {{outE().inV().simplePath()}} into
> {{out().simplePath()}}, which will return a wrong result as soon as there is
> more than 1 edge between a pair of vertices.
> The set {{INVALIDATING_STEP_CLASSES}} should only contain
> {{PathProcessor.class}} and {{LambdaHolder.class}} Furthermore
> {{SimplePathStep}} should implement {{PathProcessor}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
