[
https://issues.apache.org/jira/browse/TINKERPOP-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15657249#comment-15657249
]
ASF GitHub Bot commented on TINKERPOP-1545:
-------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/488
TINKERPOP-1545 IncidentToAdjacentStrategy is buggy (tp32)
https://issues.apache.org/jira/browse/TINKERPOP-1545
Made SimplePathStep implement PathProcessor and IncidentToAdjacentStrategy
skip all traversals that contain path processing steps.
VOTE: +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1545-tp32
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #488
----
commit 82be4395a9798bc1c1e4260f169fbfb61c05d5c6
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date: 2016-11-10T23:00:03Z
Made IncidentToAdjacentStrategy skip all traversals that contain steps with
a `PATH` requirement.
commit fcf9320ea8355bc83bb32780820e186e18c6bcb2
Author: Daniel Kuppitz <daniel_kupp...@hotmail.com>
Date: 2016-11-11T13:26:46Z
Merge branch 'TINKERPOP-1545' into TINKERPOP-1545-tp32
----
> IncidentToAdjacentStrategy is buggy
> -----------------------------------
>
> Key: TINKERPOP-1545
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1545
> Project: TinkerPop
> Issue Type: Bug
> Affects Versions: 3.1.4, 3.2.3
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
>
> {{IncidentToAdjacentStrategy}} turns {{outE().inV().simplePath()}} into
> {{out().simplePath()}}, which will return a wrong result as soon as there is
> more than 1 edge between a pair of vertices.
> The set {{INVALIDATING_STEP_CLASSES}} should only contain
> {{PathProcessor.class}} and {{LambdaHolder.class}} Furthermore
> {{SimplePathStep}} should implement {{PathProcessor}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
