[
https://issues.apache.org/jira/browse/TINKERPOP-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16038735#comment-16038735
]
ASF GitHub Bot commented on TINKERPOP-915:
------------------------------------------
GitHub user krlohnes opened a pull request:
https://github.com/apache/tinkerpop/pull/618
[TINKERPOP-915]Add combined handler for Http and Websockets
[TINKERPOP-915](https://issues.apache.org/jira/browse/TINKERPOP-915)
Most of this is tests. I added an integration test that goes over the
functionality of both the http and websocket channelizers using the new
`WsAndHttpChannelizer`. I added an additional test on top of that to
switch between using WebSockets and http.
The change itself leverages the existing `WebSocketChannelizer` to
provide the base pipeline setup. It has everything needed handler-wise
to service both http and ws connections. The
`WsAndHttpChannelizerHandler` then detects whether the incoming request
is a plain http connection or a WebSockets connection. If it's an http
connection, the channelizer handler swaps out the request handler
appropriately for whether or not authentication has been enabled.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krlohnes/tinkerpop
add_combined_http_ws_handler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/618.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #618
----
commit 928d9a6566a4387fd91f43425f8a6ff77a7bce66
Author: Keith Lohnes <krloh...@us.ibm.com>
Date: 2017-05-30T14:02:54Z
[TINKERPOP-915]Add combined handler for Http and Websockets
[TINKERPOP-915](https://issues.apache.org/jira/browse/TINKERPOP-915)
Most of this is tests. I added an integration test that goes over the
functionality of both the http and websocket channelizers using the new
`WsAndHttpChannelizer`. I added an additional test on top of that to
switch between using WebSockets and http.
The change itself leverages the existing `WebSocketChannelizer` to
provide the base pipeline setup. It has everything needed handler-wise
to service both http and ws connections. The
`WsAndHttpChannelizerHandler` then detects whether the incoming request
is a plain http connection or a WebSockets connection. If it's an http
connection, the channelizer handler swaps out the request handler
appropriately for whether or not authentication has been enabled.
----
> Gremlin Server supports REST and Websockets simultanteously
> -----------------------------------------------------------
>
> Key: TINKERPOP-915
> URL: https://issues.apache.org/jira/browse/TINKERPOP-915
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
>
> Develop a {{Channelizer}} that allows REST and Websockets to be configured at
> the same time. I've personally tried to do this on a couple of attempts
> while following a Netty sample, but I've never been able to get it to work.
> Perhaps folks like [~pluradj] or [~dmill] would like to give it a go some
> day? :)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
