[
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043013#comment-16043013
]
Florian Hockmann commented on TINKERPOP-1552:
---------------------------------------------
Wow, that looks really nice, [~jorgebg]! I just have two questions:
# Is there a reason why you didn't also add a type parameter to {{Traverser}}?
That would make it possible to be type-safe all the way down to the driver if I
didn't miss something.
# What do you mean with the comment in the test
{{g_V_HasXname_markoX_ValueMap_Next}} from {{GraphTraversalTests}}:
{code}
//Unable to cast object of type
//'System.Collections.Generic.Dictionary`2[System.String,System.Object]' to
type
//'System.Collections.Generic.IDictionary`2[System.String,System.Collections.Generic.IList`1[System.Object]]'.
{code}
It seems to work just fine.
Your changes also allow to cleanup the tests a bit as they contain many
explicit type conversions that aren't needed anymore.
And thank you [~spmallette] for cleaning up the poms! It was really the first
time that I worked with Maven, hence all the unnecessary declarations. I am
just seeing an error now when the Gremlin Server should be started / stopped
for the integration tests with the inlined Groovy script:
{code}
Unable to initialize 'ant' with a new AntBuilder object. Is Groovy a
dependency? If you are using Groovy >= 2.3.0-rc-1, remember to include
groovy-ant as a dependency
{code}
Nevertheless, everything seems to work anyway. At least all tests pass. I am
also not 100% sure that this error didn't occur before.
> C# Gremlin Language Variant
> ---------------------------
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
> Issue Type: Improvement
> Components: language-variant
> Affects Versions: 3.2.3
> Reporter: Jorge Bay
> Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of
> the trickier bits to deal with.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
