[
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044218#comment-16044218
]
Jorge Bay commented on TINKERPOP-1552:
--------------------------------------
bq. I would suggest that we review each others pull requests before they are
getting merged in
Agree! it's easier to discuss and fix on github before merging it. I guess a TK
committer merged it directly to the dev branch confusing me with you, the
author of the C# GLV (I'm the author of the JS GLV on TINKERPOP-1489 dev
branch).
bq. Ok, I see the problem. The deserializing only gets its type information
from the GraphSON which doesn't include the type of the traversed object.
We _could_ fix that issue by using {{Traverser<object>}} for
{{TraverserReader}} and {{TraverserAggregator}} references, but I wouldn't know
the implications.
> C# Gremlin Language Variant
> ---------------------------
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
> Issue Type: Improvement
> Components: language-variant
> Affects Versions: 3.2.3
> Reporter: Jorge Bay
> Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of
> the trickier bits to deal with.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
