[
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044488#comment-16044488
]
ASF GitHub Bot commented on TINKERPOP-1552:
-------------------------------------------
GitHub user FlorianHockmann opened a pull request:
https://github.com/apache/tinkerpop/pull/623
TINKERPOP-1552: Minor code cleanup for Gremlin.Net
https://issues.apache.org/jira/browse/TINKERPOP-1552
This mainly removes explicit type castings that are now obsolete thanks to
changes from the pull request #620 from @jorgebay. It also makes the Dictionary
CSharpToJavaEnums in NamingConversions private to avoid direct access to it as
GetEnumJavaName should be used instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/FlorianHockmann/tinkerpop dotnet-glv-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/623.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #623
----
commit 68c5a0cbb368f18f1e8650a84eee2f56e3bc2507
Author: Florian Hockmann <f...@florian-hockmann.de>
Date: 2017-06-09T14:14:49Z
Minor code cleanup for Gremlin.Net
This mainly removes explicit type casting that are now obsolete thanks to
changes from the pull request #620. It also makes the Dictionary
CSharpToJavaEnums in NamingConversions private to avoid direct access to it as
GetEnumJavaName should be used instead.
----
> C# Gremlin Language Variant
> ---------------------------
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
> Issue Type: Improvement
> Components: language-variant
> Affects Versions: 3.2.3
> Reporter: Jorge Bay
> Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of
> the trickier bits to deal with.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
