[
https://issues.apache.org/jira/browse/TINKERPOP-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630063#comment-17630063
]
ASF GitHub Bot commented on TINKERPOP-2480:
-------------------------------------------
spmallette commented on code in PR #1838:
URL: https://github.com/apache/tinkerpop/pull/1838#discussion_r1015956869
##########
docs/src/reference/gremlin-variants.asciidoc:
##########
@@ -329,6 +329,7 @@ The following table describes the various configuration
options for the Gremlin
|serializer.config |A `Map` of configuration settings for the serializer.
|_none_
|username |The username to submit on requests that require authentication.
|_none_
|workerPoolSize |Size of the pool for handling background work. |available
processors * 2
+|enableWsHandshakeUserAgent |Configures the channelizer to send a user agent
during web socket handshakes. |true
Review Comment:
1. It doesn't necessarily have to be here in this table, but i think the
user will need more details as to what effect this setting has.
2. `enableWsHandshakeUserAgent` says what it is but isn't really clear at
first read? maybe `enableUserAgentOnConnect` would be more descriptive?
> User agent for Gremlin drivers
> ------------------------------
>
> Key: TINKERPOP-2480
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2480
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
>
> Currently, a server does not distinguish amongst the different types of
> clients connecting to it. This issue is to add a new feature to add user
> agent field in the HTTP and WebSocket request header which could be used to
> identify the specific client from which the request was made.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
