[
https://issues.apache.org/jira/browse/TINKERPOP-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631011#comment-17631011
]
ASF GitHub Bot commented on TINKERPOP-2480:
-------------------------------------------
spmallette commented on code in PR #1838:
URL: https://github.com/apache/tinkerpop/pull/1838#discussion_r1017821994
##########
docs/src/reference/gremlin-variants.asciidoc:
##########
@@ -682,6 +683,14 @@ This command will generate a new Maven project in a
directory called "app" with
`com.my`. Please see the `README.asciidoc` in the root of each generated
project for information on how to build and
execute it.
+[[gremlin-java-user-agent]]
+=== User Agent
Review Comment:
i wouldn't make this a separate top-level section as GLVs have a set form. i
was going to suggest you could make it a fourth level section under
`gremlin-java-configuration` but i feel like this the "user agent" is just
going to then have to be replicated for each GLV. I'm starting to think about
this differently now. This new use of user agent is technically a standard that
drivers should adhere to. I think you should document it as such in the
[Provider
Documentation](https://github.com/apache/tinkerpop/blob/master/docs/src/dev/provider/index.asciidoc#graph-driver-provider-requirements)
where you should include the expected format, examples, etc. Then you can just
add a link to that from your little configuration description if folks want to
know what the "use agent" is. Finally in the Upgrade Documentation you should
make mention of this new feature in the Provider section to call attention to
it. how does that sound?
> User agent for Gremlin drivers
> ------------------------------
>
> Key: TINKERPOP-2480
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2480
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
>
> Currently, a server does not distinguish amongst the different types of
> clients connecting to it. This issue is to add a new feature to add user
> agent field in the HTTP and WebSocket request header which could be used to
> identify the specific client from which the request was made.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
