[
https://issues.apache.org/jira/browse/TINKERPOP-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699844#comment-17699844
]
ASF GitHub Bot commented on TINKERPOP-2747:
-------------------------------------------
disq commented on code in PR #1989:
URL: https://github.com/apache/tinkerpop/pull/1989#discussion_r1134640693
##########
gremlin-go/driver/client_test.go:
##########
@@ -40,13 +41,13 @@ func TestClient(t *testing.T) {
settings.AuthInfo = testNoAuthAuthInfo
})
defer client.Close()
- assert.Nil(t, err)
+ assert.NoError(t, err)
Review Comment:
Errcheck assertion is traditionally done with `assert.NoError`. There are
couple more files with this slight inconvenience which I chose not to touch for
now.
> Add function callback hooks for gremlin-go authentication
> ---------------------------------------------------------
>
> Key: TINKERPOP-2747
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2747
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Reporter: Lyndon Bauto
> Priority: Major
>
> Gremlin Go currently supports custom authentication headers.
>
> For long running connections that reconnect over time, these headers can
> expire.
>
> We should allow injection of a function pointer to generate the header.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
