[
https://issues.apache.org/jira/browse/TINKERPOP-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17699899#comment-17699899
]
ASF GitHub Bot commented on TINKERPOP-2747:
-------------------------------------------
Cole-Greer commented on code in PR #1989:
URL: https://github.com/apache/tinkerpop/pull/1989#discussion_r1134797403
##########
gremlin-go/driver/connection.go:
##########
@@ -42,15 +42,15 @@ type connection struct {
}
type connectionSettings struct {
- authInfo *AuthInfo
- tlsConfig *tls.Config
- keepAliveInterval time.Duration
- writeDeadline time.Duration
- connectionTimeout time.Duration
- enableCompression bool
- readBufferSize int
- writeBufferSize int
- enableUserAgentOnConnect bool
+ authInfo AuthInfoProvider
Review Comment:
I do have some concerns with potentially breaking things for some users by
changing this type from `*AuthInfo` to `AuthInfoProvider`. As the fields in
AuthInfo were all public, there are likely users who are modifying these fields
directly instead of using the interface.
It might not be a big deal as the current expected use case is users
construct the AuthInfo struct, pass it into a new client, then never touch it
again. I don't believe the AuthInfo is publicly accessible anywhere after it
has been passed into the client.
I want to think about this a little bit more but I believe it is ok and
won't impact any users.
> Add function callback hooks for gremlin-go authentication
> ---------------------------------------------------------
>
> Key: TINKERPOP-2747
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2747
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Reporter: Lyndon Bauto
> Priority: Major
>
> Gremlin Go currently supports custom authentication headers.
>
> For long running connections that reconnect over time, these headers can
> expire.
>
> We should allow injection of a function pointer to generate the header.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
