[
https://issues.apache.org/jira/browse/TINKERPOP-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17700048#comment-17700048
]
ASF GitHub Bot commented on TINKERPOP-2747:
-------------------------------------------
disq commented on code in PR #1989:
URL: https://github.com/apache/tinkerpop/pull/1989#discussion_r1135250923
##########
gremlin-go/driver/connection.go:
##########
@@ -42,15 +42,15 @@ type connection struct {
}
type connectionSettings struct {
- authInfo *AuthInfo
- tlsConfig *tls.Config
- keepAliveInterval time.Duration
- writeDeadline time.Duration
- connectionTimeout time.Duration
- enableCompression bool
- readBufferSize int
- writeBufferSize int
- enableUserAgentOnConnect bool
+ authInfo AuthInfoProvider
Review Comment:
> I don't believe the AuthInfo is publicly accessible anywhere after it has
been passed into the client.
Since `DriverRemoteConnection.settings` itself is unexported (as per Go
export rules, it would have to be named `Settings`) I don't see a way of how
one would go about changing any setting after initialization.
> Add function callback hooks for gremlin-go authentication
> ---------------------------------------------------------
>
> Key: TINKERPOP-2747
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2747
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Reporter: Lyndon Bauto
> Priority: Major
>
> Gremlin Go currently supports custom authentication headers.
>
> For long running connections that reconnect over time, these headers can
> expire.
>
> We should allow injection of a function pointer to generate the header.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
