[
https://issues.apache.org/jira/browse/TINKERPOP-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754858#comment-17754858
]
ASF GitHub Bot commented on TINKERPOP-2982:
-------------------------------------------
rdtr commented on code in PR #2206:
URL: https://github.com/apache/tinkerpop/pull/2206#discussion_r1295382250
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/HttpGremlinRequestEncoder.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.driver.handler;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandler;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.handler.codec.MessageToMessageEncoder;
+import io.netty.handler.codec.http.DefaultFullHttpRequest;
+import io.netty.handler.codec.http.FullHttpRequest;
+import io.netty.handler.codec.http.HttpHeaderNames;
+import io.netty.handler.codec.http.HttpMethod;
+import io.netty.handler.codec.http.HttpVersion;
+import org.apache.tinkerpop.gremlin.driver.MessageSerializer;
+import org.apache.tinkerpop.gremlin.driver.Tokens;
+import org.apache.tinkerpop.gremlin.driver.exception.ResponseException;
+import org.apache.tinkerpop.gremlin.driver.message.RequestMessage;
+import org.apache.tinkerpop.gremlin.driver.message.ResponseStatusCode;
+import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
+import
org.apache.tinkerpop.gremlin.process.traversal.translator.GroovyTranslator;
+import org.apache.tinkerpop.shaded.jackson.databind.ObjectMapper;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.function.UnaryOperator;
+
+/**
+ * Converts {@link RequestMessage} to a {@code HttpRequest}.
+ */
+@ChannelHandler.Sharable
+public final class HttpGremlinRequestEncoder extends
MessageToMessageEncoder<RequestMessage> {
+ private final MessageSerializer<?> serializer;
+
+ private final ObjectMapper mapper = new ObjectMapper();
Review Comment:
Do we need to have an instance of ObjectMapper for each handler ? I believe
creating a mapper is relatively expensive operation, thus if we can make it
`static` it'd be better.
> Allow gremlin-driver usage over HTTP
> ------------------------------------
>
> Key: TINKERPOP-2982
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2982
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.6.5
> Reporter: Stephen Mallette
> Priority: Major
>
> Allow gremlin-driver to work over HTTP in addition to websockets.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
