[
https://issues.apache.org/jira/browse/TINKERPOP-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755012#comment-17755012
]
ASF GitHub Bot commented on TINKERPOP-2982:
-------------------------------------------
spmallette commented on code in PR #2206:
URL: https://github.com/apache/tinkerpop/pull/2206#discussion_r1295719943
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Host.java:
##########
@@ -49,7 +49,8 @@ public final class Host {
Host(final InetSocketAddress address, final Cluster cluster) {
this.cluster = cluster;
this.address = address;
- this.hostUri = makeUriFromAddress(address, cluster.getPath(),
cluster.connectionPoolSettings().enableSsl);
+ this.hostUri = makeUriFromAddress(address, cluster.getPath(),
cluster.connectionPoolSettings().enableSsl,
Review Comment:
yes, i often dislike that the Java driver works the way that it does, at
least insofar as how it configures host/port/scheme. like you have to do:
```groovy
g = traversal().withRemote(
DriverRemoteConnection.using("localhost", 8182))
```
but would be nice if you could do like the other drivers:
```groovy
g = traversal().withRemote(
new DriverRemoteConnection('ws://localhost:8182/gremlin'))
```
to provide a bit more flexibility for providers and how they setup their
servers. that said, imo, i do think Neptune has gone a little too far in
creating its own explain/profile endpoints. it should simply implement the
`explain()` / `profile()` steps. For what it's worth, you can use the
interceptor interface to add a custom request header now.
Anyway, feel free to open a JIRA for allowing users to specify a url to a
"gremlin endpoint" rather than our constructing one. And if you feel like we
need to somehow support other custom endpoints, I think you should start a
DISCUSS thread on the dev list.
> Allow gremlin-driver usage over HTTP
> ------------------------------------
>
> Key: TINKERPOP-2982
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2982
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.6.5
> Reporter: Stephen Mallette
> Priority: Major
>
> Allow gremlin-driver to work over HTTP in addition to websockets.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
