[
https://issues.apache.org/jira/browse/TINKERPOP-2982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757057#comment-17757057
]
ASF GitHub Bot commented on TINKERPOP-2982:
-------------------------------------------
Cole-Greer commented on code in PR #2206:
URL: https://github.com/apache/tinkerpop/pull/2206#discussion_r1300481800
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Channelizer.java:
##########
@@ -143,18 +152,18 @@ protected void initChannel(final SocketChannel
socketChannel) throws Exception {
/**
* WebSocket {@link Channelizer} implementation.
*/
- public final class WebSocketChannelizer extends AbstractChannelizer {
+ final class WebSocketChannelizer extends AbstractChannelizer {
Review Comment:
Small breaking change here. I'm not aware of any users which would be
impacted by this but I would prefer to defer such a change to the next major
release.
##########
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/handler/HttpGremlinEndpointHandler.java:
##########
@@ -49,33 +50,21 @@
import io.netty.channel.ChannelInboundHandlerAdapter;
import io.netty.channel.ChannelPromise;
import io.netty.handler.codec.TooLongFrameException;
-import io.netty.handler.codec.http.DefaultFullHttpResponse;
-import io.netty.handler.codec.http.FullHttpRequest;
-import io.netty.handler.codec.http.FullHttpResponse;
-import io.netty.handler.codec.http.HttpResponseStatus;
-import io.netty.handler.codec.http.HttpUtil;
import io.netty.util.ReferenceCountUtil;
import javax.script.Bindings;
import javax.script.SimpleBindings;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Objects;
-import java.util.Optional;
-import java.util.UUID;
+import java.util.*;
Review Comment:
There are a couple of wildcard imports introduced throughout the PR, would
prefer to avoid them.
> Allow gremlin-driver usage over HTTP
> ------------------------------------
>
> Key: TINKERPOP-2982
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2982
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.6.5
> Reporter: Stephen Mallette
> Priority: Major
>
> Allow gremlin-driver to work over HTTP in addition to websockets.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
