[ 
https://issues.apache.org/jira/browse/TINKERPOP-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946196#comment-17946196
 ] 

ASF GitHub Bot commented on TINKERPOP-3147:
-------------------------------------------

andreachild commented on code in PR #3096:
URL: https://github.com/apache/tinkerpop/pull/3096#discussion_r2052797151


##########
gremlin-test/src/main/resources/org/apache/tinkerpop/gremlin/test/features/filter/Sample.feature:
##########
@@ -18,6 +18,24 @@
 @StepClassFilter @StepSample
 Feature: Step - sample()
 
+  Scenario: g_V_aggregateXxX_byXnameX_byXageX_capXxX
+    Given the modern graph
+    And the traversal of
+      """
+      g.V().aggregate("x").by("name").by("age").cap("x")
+      """
+    When iterated to list
+    Then the traversal will raise an error

Review Comment:
   Now that https://github.com/apache/tinkerpop/pull/3094 is merged you should 
be able to check that the error message contains an expected phrase





> Prevent aggregate step from having multiple by modulators
> ---------------------------------------------------------
>
>                 Key: TINKERPOP-3147
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-3147
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: process
>    Affects Versions: 3.7.3
>            Reporter: Andrea C
>            Priority: Minor
>
> Aggregate step will ignore previous by modulators if multiple are specified, 
> which can be misleading to the user. Instead, similar to 
> https://issues.apache.org/jira/browse/TINKERPOP-3121 multiple by modulators 
> should be prevented with aggregate.
> {code:java}
> gremlin> g.V().aggregate('x').by('name').cap('x')
> ==>[marko,vadas,lop,josh,ripple,peter]
> gremlin> g.V().aggregate('x').by('name').by('age').cap('x')
> ==>[29,27,32,35] {code}
>  
> Note that `store` step is an alias to `aggregate` and should also be 
> prevented from having multiple by modulators.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to