[
https://issues.apache.org/jira/browse/TINKERPOP-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17949096#comment-17949096
]
ASF GitHub Bot commented on TINKERPOP-3147:
-------------------------------------------
codecov-commenter commented on PR #3113:
URL: https://github.com/apache/tinkerpop/pull/3113#issuecomment-2848229121
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3113?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 78.13%. Comparing base
[(`cfd6889`)](https://app.codecov.io/gh/apache/tinkerpop/commit/cfd68897ea111e3ae7100dbc2f0f7a364fd0ffa5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`15b562b`)](https://app.codecov.io/gh/apache/tinkerpop/commit/15b562b8533fcc349178673076daaf451cc1f8be?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 227 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3113 +/- ##
============================================
+ Coverage 77.87% 78.13% +0.26%
- Complexity 13578 13753 +175
============================================
Files 1015 1023 +8
Lines 59308 59974 +666
Branches 6835 7004 +169
============================================
+ Hits 46184 46860 +676
+ Misses 10817 10769 -48
- Partials 2307 2345 +38
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3113?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> Prevent aggregate step from having multiple by modulators
> ---------------------------------------------------------
>
> Key: TINKERPOP-3147
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3147
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.7.3
> Reporter: Andrea C
> Priority: Minor
>
> Aggregate step will ignore previous by modulators if multiple are specified,
> which can be misleading to the user. Instead, similar to
> https://issues.apache.org/jira/browse/TINKERPOP-3121 multiple by modulators
> should be prevented with aggregate.
> {code:java}
> gremlin> g.V().aggregate('x').by('name').cap('x')
> ==>[marko,vadas,lop,josh,ripple,peter]
> gremlin> g.V().aggregate('x').by('name').by('age').cap('x')
> ==>[29,27,32,35] {code}
>
> Note that `store` step is an alias to `aggregate` and should also be
> prevented from having multiple by modulators.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
