[
https://issues.apache.org/jira/browse/TINKERPOP-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18008119#comment-18008119
]
ASF GitHub Bot commented on TINKERPOP-3141:
-------------------------------------------
codecov-commenter commented on PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#issuecomment-3090241171
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/3161?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 74.22%. Comparing base
[(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`83537b7`)](https://app.codecov.io/gh/apache/tinkerpop/commit/83537b78fbb213172c08a34f3ca4f84fd4dffa57?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 349 commits behind head on 3.7-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.7-dev #3161 +/- ##
=============================================
- Coverage 76.14% 74.22% -1.92%
=============================================
Files 1084 28 -1056
Lines 65160 5913 -59247
Branches 7285 0 -7285
=============================================
- Hits 49616 4389 -45227
+ Misses 12839 1322 -11517
+ Partials 2705 202 -2503
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/3161?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
- :package: [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save
yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
> TinkerTransactionGraph doesn't allow deleting and adding element back in same
> transaction
> -----------------------------------------------------------------------------------------
>
> Key: TINKERPOP-3141
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3141
> Project: TinkerPop
> Issue Type: Bug
> Components: tinkergraph
> Affects Versions: 3.7.3
> Reporter: Ken Hu
> Priority: Critical
>
> Originally discovered from:
> https://stackoverflow.com/questions/79467860/issue-with-transactions-in-local-tinkerpop-gremlin-setup
> [https://groups.google.com/g/gremlin-users/c/NRwb4xy2eXs]
>
> An element with the same Id cannot be dropped and then added back in the same
> transaction.
>
> {code:java}
> @Test
> public void shouldAllowDropThenInsert() throws InterruptedException {
> final TinkerTransactionGraph g = TinkerTransactionGraph.open();
> final GraphTraversalSource gtx = g.tx().begin();
> gtx.addV().property(T.id, 1).next();
> gtx.tx().commit();
> GraphTraversalSource gtx2 = g.tx().begin();
> gtx2.V().drop().iterate();
> gtx.addV().property(T.id, 1).next();
> gtx2.tx().commit();
> assertEquals(1, g.getVertices().size());
> } {code}
> throws a TransactionException.
> This occurs when the transaction attempts to get updated, the old
> vertex"isDeletedInTx" but has a different txNumber than the newly created
> vertex.
> [https://github.com/apache/tinkerpop/blob/3.7.3/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerElementContainer.java#L185]
> should probably allow this case through.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
