[
https://issues.apache.org/jira/browse/TINKERPOP-3141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18008161#comment-18008161
]
ASF GitHub Bot commented on TINKERPOP-3141:
-------------------------------------------
vkagamlyk commented on code in PR #3161:
URL: https://github.com/apache/tinkerpop/pull/3161#discussion_r2216919114
##########
tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerTransactionGraph.java:
##########
@@ -152,11 +152,19 @@ public Vertex addVertex(final Object... keyValues) {
if (container != null && container.get() != null)
throw Exceptions.vertexWithIdAlreadyExists(idValue);
+ long version = txNumber;
+ if (container != null && container.isDeleted() &&
container.getModified() != null) {
+ // vertex being added was previously deleted
+ // we need to reference the version from the deleted state when
adding the vertex back
+ version = container.getModified().version();
+ container.unmarkDeleted((TinkerTransaction) tx());
+ }
+
// no existing container, let's use new one
if (container == null)
container = newContainer;
- final TinkerVertex vertex = new TinkerVertex(idValue, label, this,
txNumber);
+ final TinkerVertex vertex = new TinkerVertex(idValue, label, this,
version);
Review Comment:
I think you're right, for scenario remove-add in same transaction better to
preserve version, so `updatedOutsideTransaction()` will be correct.
and the test confirms it
> TinkerTransactionGraph doesn't allow deleting and adding element back in same
> transaction
> -----------------------------------------------------------------------------------------
>
> Key: TINKERPOP-3141
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3141
> Project: TinkerPop
> Issue Type: Bug
> Components: tinkergraph
> Affects Versions: 3.7.3
> Reporter: Ken Hu
> Priority: Critical
>
> Originally discovered from:
> https://stackoverflow.com/questions/79467860/issue-with-transactions-in-local-tinkerpop-gremlin-setup
> [https://groups.google.com/g/gremlin-users/c/NRwb4xy2eXs]
>
> An element with the same Id cannot be dropped and then added back in the same
> transaction.
>
> {code:java}
> @Test
> public void shouldAllowDropThenInsert() throws InterruptedException {
> final TinkerTransactionGraph g = TinkerTransactionGraph.open();
> final GraphTraversalSource gtx = g.tx().begin();
> gtx.addV().property(T.id, 1).next();
> gtx.tx().commit();
> GraphTraversalSource gtx2 = g.tx().begin();
> gtx2.V().drop().iterate();
> gtx.addV().property(T.id, 1).next();
> gtx2.tx().commit();
> assertEquals(1, g.getVertices().size());
> } {code}
> throws a TransactionException.
> This occurs when the transaction attempts to get updated, the old
> vertex"isDeletedInTx" but has a different txNumber than the newly created
> vertex.
> [https://github.com/apache/tinkerpop/blob/3.7.3/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerElementContainer.java#L185]
> should probably allow this case through.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
