[
https://issues.apache.org/jira/browse/TINKERPOP3-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558476#comment-14558476
]
Ran Magen commented on TINKERPOP3-695:
--------------------------------------
All the OptOuts needed when using option 2 that Stephen suggested:
@Graph.OptOut(test =
"org.apache.tinkerpop.gremlin.structure.FeatureSupportTest$VertexPropertyFunctionalityTest",
method = "shouldSupportNumericIdsIfNumericIdsAreGeneratedFromTheGraph",
reason = "https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test =
"org.apache.tinkerpop.gremlin.structure.FeatureSupportTest$EdgeFunctionalityTest",
method = "shouldSupportUserSuppliedIdsOfTypeUuid",
reason = "https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test =
"org.apache.tinkerpop.gremlin.structure.FeatureSupportTest$EdgeFunctionalityTest",
method = "shouldSupportUserSuppliedIdsOfTypeAny",
reason = "https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test =
"org.apache.tinkerpop.gremlin.structure.FeatureSupportTest$EdgeFunctionalityTest",
method = "shouldSupportUserSuppliedIdsOfTypeNumeric",
reason = "https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test =
"org.apache.tinkerpop.gremlin.structure.FeatureSupportTest$VertexFunctionalityTest",
method = "shouldSupportUserSuppliedIdsOfTypeUuid",
reason = "https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test =
"org.apache.tinkerpop.gremlin.structure.FeatureSupportTest$VertexFunctionalityTest",
method = "shouldSupportUserSuppliedIdsOfTypeAny",
reason = "https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test =
"org.apache.tinkerpop.gremlin.structure.FeatureSupportTest$VertexFunctionalityTest",
method = "shouldSupportUserSuppliedIdsOfTypeNumeric",
reason = "https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldReadWriteModernToGryo",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldReadWriteModernToGraphSON",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldReadWriteModernToGryoToFileWithHelpers",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldReadWriteClassicToGraphMLToFileWithHelpers",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldMigrateGraphWithFloat",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldMigrateGraph",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldReadWriteClassicToGraphSON",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldReadWriteClassicToGryo",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
@Graph.OptOut(test = "org.apache.tinkerpop.gremlin.structure.io.IoTest", method
= "shouldReadWriteModernToGraphSONWithHelpers",
reason = "IoTest.assertId(IoTest.java:2362) doesn't call convertId.
https://issues.apache.org/jira/browse/TINKERPOP3-695";)
> test not calling convertId()
> ----------------------------
>
> Key: TINKERPOP3-695
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-695
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: test-suite
> Reporter: Ran Magen
> Assignee: stephen mallette
>
> any test that uses Attachable to load its graph (e.g. using the Gryo loader)
> will not pass the id through the graph providers convertId(id). there are
> around 60 different tests affected.
> The offending line:
> https://github.com/apache/incubator-tinkerpop/blob/4bbbb6365f36c20ad63ca4665657fd1169a7d246/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/Attachable.java#L276
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
